Remove npm references from Contributing #1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
Jan 3, 2020
Member
Author
Hm, I didn't want to change the release scripts as they are working fine (AFAIK). Same thing with package.json scripts as long as they are run using |
Member
|
Your call - I think it makes sense to pick and stick w/ a single package manager. It's basically as easy as |
Member
|
Since moving the scripts from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1235 (sorta...)
Right now,
npmis not a valid option as the project won't run properly. Onlyyarnis. Thus, I updated the docs accordingly.In an ideal world, running VTU scripts with
npmwould "just work", but I'm not experienced enough with Lerna to identify what's missing. That's why I thought that, at least, we should make the docs reflect the current state of the art.